Skip to content

gh-103793: Defer formatting task name #103767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 14 commits into from
Apr 29, 2023
Merged

gh-103793: Defer formatting task name #103767

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e8353cc
Defer formatting task name
itamaro Apr 24, 2023
1822ff8
Defer task name formatting also in Python Task impl
itamaro Apr 24, 2023
74d0084
Add NEWS and whatsnew entries
itamaro Apr 24, 2023
dbc7047
Merge branch 'main' into defer-task-name-formatting
ambv Apr 25, 2023
2bb6c1e
Merge branch 'main' into defer-task-name-formatting
itamaro Apr 25, 2023
2efd376
replace storing the task counter on task construction with just getti…
itamaro Apr 25, 2023
6cb321b
Merge branch 'defer-task-name-formatting' of github.com:itamaro/cpyth…
itamaro Apr 25, 2023
7cde290
remove redundant return
itamaro Apr 25, 2023
4b50646
Merge branch 'main' into defer-task-name-formatting
itamaro Apr 25, 2023
a155190
revert changes to python version
itamaro Apr 25, 2023
fb2bd7f
pass error up if PyUnicode_FromFormat returns NULL
itamaro Apr 25, 2023
41e9a59
Switch back to original "assign task number at construction" but stor…
itamaro Apr 26, 2023
712edf9
Add test that using an explicit PyLong as task name does not accident…
itamaro Apr 26, 2023
592d44b
Merge branch 'main' into defer-task-name-formatting
itamaro Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pass error up if PyUnicode_FromFormat returns NULL
  • Loading branch information
@itamaro
itamaro committed Apr 25, 2023
commit fb2bd7fbf086b633e8b0fcc49dc3f24ec6b7951c
3 changes: 3 additions & 0 deletions Modules/_asynciomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2455,6 +2455,9 @@ _asyncio_Task_get_name_impl(TaskObj *self)
PyObject *name = PyUnicode_FromFormat(
"Task-%" PRIu64, ++state->task_name_counter);
Comment thread
itamaro marked this conversation as resolved.
Outdated
Py_XSETREF(self->task_name, name);
if (self->task_name == NULL) {
return NULL;
}
}
return Py_NewRef(self->task_name);
}
Expand Down