Skip to content

gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers #103674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 11 commits into from
Apr 24, 2023
Merged

gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers #103674

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8a2f842
socketserver: Add missing ForkingUnixStreamServer and ForkingUnixData…
jb2170 Apr 22, 2023
364eb77
Add self to Misc/ACKS
jb2170 Apr 22, 2023
849feb2
Add NEWS entry with blurb
jb2170 Apr 22, 2023
d634059
style nit: add a missing space.
gpshead Apr 23, 2023
a9a91ed
ReSTify the NEWS entry.
gpshead Apr 23, 2023
e32b567
remove an unnecessary word in NEWS
gpshead Apr 23, 2023
58073d4
Add authorship
arhadthedev Apr 24, 2023
5f61e05
Update Lib/test/test_socketserver.py to use ForkingUnix{Stream,Datagr…
jb2170 Apr 24, 2023
afb4520
Merge branch 'main' into gh-103673
jb2170 Apr 24, 2023
7d0ac34
Merge branch 'main' into gh-103673
gpshead Apr 24, 2023
ee13a90
Add a versionadded 3.12 tag.
gpshead Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_socketserver.py to use ForkingUnix{Stream,Datagr… 
…am}Server from socketserver
  • Loading branch information
@jb2170
jb2170 committed Apr 24, 2023
commit 5f61e059f7e6d0c6e748c060dedad7eeb0bb04b8
13 changes: 2 additions & 11 deletions Lib/test/test_socketserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,6 @@ def receive(sock, n, timeout=test.support.SHORT_TIMEOUT):
else:
raise RuntimeError("timed out on %r" % (sock,))

if HAVE_UNIX_SOCKETS and HAVE_FORKING:
class ForkingUnixStreamServer(socketserver.ForkingMixIn,
socketserver.UnixStreamServer):
pass

class ForkingUnixDatagramServer(socketserver.ForkingMixIn,
socketserver.UnixDatagramServer):
pass


@contextlib.contextmanager
def simple_subprocess(testcase):
Expand Down Expand Up @@ -211,7 +202,7 @@ def test_ThreadingUnixStreamServer(self):
@requires_forking
def test_ForkingUnixStreamServer(self):
with simple_subprocess(self):
self.run_server(ForkingUnixStreamServer,
self.run_server(socketserver.ForkingUnixStreamServer,
socketserver.StreamRequestHandler,
self.stream_examine)

Expand Down Expand Up @@ -247,7 +238,7 @@ def test_ThreadingUnixDatagramServer(self):
@requires_unix_sockets
@requires_forking
def test_ForkingUnixDatagramServer(self):
self.run_server(ForkingUnixDatagramServer,
self.run_server(socketserver.ForkingUnixDatagramServer,
socketserver.DatagramRequestHandler,
self.dgram_examine)

Expand Down