Skip to content

gh-103556: [inspect.Signature] disallow pos-or-kw params without default after pos-only with default #103557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carljm merged 4 commits into from
Apr 22, 2023
Merged

gh-103556: [inspect.Signature] disallow pos-or-kw params without default after pos-only with default #103557

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
578f998
gh-103556: [inspect.Signature] disallow pos-or-kw params without defa…
sobolevn Apr 15, 2023
a4cf538
Update Lib/test/test_inspect.py
sobolevn Apr 15, 2023
d6ef93a
Address review
sobolevn Apr 19, 2023
261d9d1
Merge branch 'issue-103556' of https://github.com/sobolevn/cpython in…
sobolevn Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Apr 19, 2023
commit d6ef93a68fdfa5f71490a13caa1a704dbb45d189
15 changes: 4 additions & 11 deletions Lib/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3006,7 +3006,7 @@ def __init__(self, parameters=None, *, return_annotation=_empty,
if __validate_parameters__:
params = OrderedDict()
top_kind = _POSITIONAL_ONLY
kind_defaults = False
seen_default = False

for param in parameters:
kind = param.kind
Expand All @@ -3021,26 +3021,19 @@ def __init__(self, parameters=None, *, return_annotation=_empty,
kind.description)
raise ValueError(msg)
elif kind > top_kind:
if (top_kind != _POSITIONAL_ONLY
and kind != _POSITIONAL_OR_KEYWORD):
# We still have to maintain defaults in cases like
# def some(pod=42, /, pk=1): ...
# Here `pk` must have a default value.
kind_defaults = False
top_kind = kind

if kind in (_POSITIONAL_ONLY, _POSITIONAL_OR_KEYWORD):
if param.default is _empty:
if kind_defaults:
if seen_default:
# No default for this parameter, but the
# previous parameter of the same kind had
# a default
# previous parameter of had a default
msg = 'non-default argument follows default ' \
'argument'
raise ValueError(msg)
else:
# There is a default for this parameter.
kind_defaults = True
seen_default = True

if name in params:
msg = 'duplicate parameter name: {!r}'.format(name)
Expand Down