Skip to content

gh-101517: fix line number propagation in code generated for except* #103550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 5 commits into from
Apr 24, 2023
+27 −15
Merged

gh-101517: fix line number propagation in code generated for except* #103550

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb2b5a5
gh-101517: fix line number propagation in code generated for except*
iritkatriel Apr 14, 2023
58c883e
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 14, 2023
073c860
add warning to s
iritkatriel Apr 14, 2023
6f4c26c
Add prefix
iritkatriel Apr 14, 2023
293cefe
Merge branch 'main' into propagate_linenos
iritkatriel Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add warning to s
  • Loading branch information
@iritkatriel
iritkatriel committed Apr 14, 2023
commit 073c8608c61fb85914833f10da7f285c4904bec3
2 changes: 1 addition & 1 deletion Lib/bdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ def format_stack_entry(self, frame_lineno, lprefix=': '):
if line:
s += lprefix + line.strip()
else:
print('bdb.Bdb.format_stack_entry: lineno is None')
s += '\nWarning: lineno is None'
Comment thread
iritkatriel marked this conversation as resolved.
Outdated
return s

# The following methods can be called by clients to use
Expand Down
3 changes: 2 additions & 1 deletion Lib/test/test_bdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,8 @@ def main():
class TestRegressions(unittest.TestCase):
def test_format_stack_entry_no_lineno(self):
# See gh-101517
Bdb().format_stack_entry((sys._getframe(), None))
self.assertIn('Warning: lineno is None',
Bdb().format_stack_entry((sys._getframe(), None)))


if __name__ == "__main__":
Expand Down