Skip to content

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer #103339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 8 commits into from
Jun 8, 2023
Merged

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer #103339

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1178a32
gh-102832: [idle] reduce use of deprecated sys.last_xyzs
iritkatriel Apr 7, 2023
a16e192
remove last_xyzs from test as well
iritkatriel Apr 7, 2023
b7ef0e1
tolerate exc == None
iritkatriel Apr 7, 2023
632533e
Merge remote-tracking branch 'upstream/main' into pr_103339
terryjreedy Jun 8, 2023
7a6839b
Fix StackBrowser def and test calls.
terryjreedy Jun 8, 2023
e84e58f
Fix pyshell -n mode Stackbrowser call.
terryjreedy Jun 8, 2023
144d3fd
Fix StackTreeItem def and calls.
terryjreedy Jun 8, 2023
bbd7e0c
indent fix
terryjreedy Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix pyshell -n mode Stackbrowser call. 
Tested by running in -n mode.
  • Loading branch information
@terryjreedy
terryjreedy committed Jun 8, 2023
commit e84e58f121a5cea4bc94656645a5f5b2da441da0
12 changes: 6 additions & 6 deletions Lib/idlelib/pyshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1363,19 +1363,19 @@ def runit(self):
self.text.tag_remove(self.user_input_insert_tags, index_before)
self.shell_sidebar.update_sidebar()

def open_stack_viewer(self, event=None):
def open_stack_viewer(self, event=None): # -n mode only
if self.interp.rpcclt:
return self.interp.remote_stack_viewer()

from idlelib.stackviewer import StackBrowser
try:
sys.last_traceback
StackBrowser(self.root, sys.last_value, self.flist)
except:
messagebox.showerror("No stack trace",
"There is no stack trace yet.\n"
"(sys.last_traceback is not defined)",
"(sys.last_value is not defined)",
Comment thread
terryjreedy marked this conversation as resolved.
parent=self.text)
return
from idlelib.stackviewer import StackBrowser
StackBrowser(self.root, self.flist)
return None

def view_restart_mark(self, event=None):
self.text.see("iomark")
Expand Down