Skip to content

gh-103272: add regression test for getattr that raises #103336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 6 commits into from
Apr 7, 2023
Merged

gh-103272: add regression test for getattr that raises #103336

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1f461f
add test case for gh-103272
sunmy2019 Apr 7, 2023
59ff49a
add news
sunmy2019 Apr 7, 2023
21f7ec7
Merge branch 'main' into test-case-for-gh-103272
sobolevn Apr 7, 2023
d9e7600
simplify test case, remove NEWS
sunmy2019 Apr 7, 2023
7f28066
nit: remove extra line
sunmy2019 Apr 7, 2023
938dca9
use assertRaisesRegex instead of assertRaises
sunmy2019 Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify test case, remove NEWS
  • Loading branch information
@sunmy2019
sunmy2019 committed Apr 7, 2023
commit d9e7600b567f3447e2c09b5a25708d979aa001e3
13 changes: 3 additions & 10 deletions Lib/test/test_descr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5004,22 +5004,15 @@ class Child(Parent):
gc.collect()
self.assertEqual(Parent.__subclasses__(), [])

def test_getattribute(self):
def test_attr_raise_through_property(self):
# add test case for gh-103272
class A:
def __init__(self) -> None:
self.bar = 0

def __getattribute__(self, name):
return super().__getattribute__(name)

def __getattr__(self, name):
if self.bar == 0:
raise ValueError
raise ValueError
Comment thread
sunmy2019 marked this conversation as resolved.
Outdated

@property
def foo(self):
return self.__getattr__("foo")
return self.__getattr__("asdf")

with self.assertRaises(ValueError):
A().foo
Expand Down
1 change: 0 additions & 1 deletion Misc/NEWS.d/next/Tests/2023-04-07-07-56-39.gh-issue-103272.QosA_L.rst
View file
Open in desktop

This file was deleted.