gh-67837: avoid race condition creating tarfile parent directories#103263
Closed
shughes-uk wants to merge 4 commits into
Closed
gh-67837: avoid race condition creating tarfile parent directories#103263shughes-uk wants to merge 4 commits into
shughes-uk wants to merge 4 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Member
|
Thank you for your PR @shughes-uk. This change needs tests, and writing tests for it is something non-trivial, especially for first-time contributor, so I created a separate PR #115082 with tests and fixes. I added you as a co-author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a race condition detailed in #67837. It does not attempt to make
tarfilecompletely thread safe but would be a small appreciated change!