Skip to content

gh-103015: Add entrypoint parameter to sqlite3.Connection.load_extension #103073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 8 commits into from
Apr 26, 2023
Merged

gh-103015: Add entrypoint parameter to sqlite3.Connection.load_extension #103073

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f232792
Add 'entrypoint' keyword arg to load_extension()
erlend-aasland Mar 27, 2023
094d8e2
Add docs
erlend-aasland Mar 28, 2023
9d132cd
make regen-all
erlend-aasland Mar 28, 2023
b405cc1
Pull in main
erlend-aasland Apr 8, 2023
a2052d2
Pull in main
erlend-aasland Apr 24, 2023
c22350a
Pull in main again
erlend-aasland Apr 25, 2023
45a7a08
Address review
erlend-aasland Apr 25, 2023
89b272a
Link to SQLite docs and try to improve wording
erlend-aasland Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add 'entrypoint' keyword arg to load_extension()
  • Loading branch information
@erlend-aasland
erlend-aasland committed Mar 27, 2023
commit f23279220635ff8849125de98d3d2a4d694fec03
73 changes: 64 additions & 9 deletions Modules/_sqlite/clinic/connection.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions Modules/_sqlite/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1601,14 +1601,17 @@ _sqlite3.Connection.load_extension as pysqlite_connection_load_extension

name as extension_name: str
/
*
entrypoint: str(accept={str, NoneType}) = None

Load SQLite extension module.
[clinic start generated code]*/

static PyObject *
pysqlite_connection_load_extension_impl(pysqlite_Connection *self,
const char *extension_name)
/*[clinic end generated code: output=47eb1d7312bc97a7 input=edd507389d89d621]*/
const char *extension_name,
const char *entrypoint)
/*[clinic end generated code: output=7e61a7add9de0286 input=c36b14ea702e04f5]*/
{
int rc;
char* errmsg;
Expand All @@ -1621,7 +1624,7 @@ pysqlite_connection_load_extension_impl(pysqlite_Connection *self,
return NULL;
}

rc = sqlite3_load_extension(self->db, extension_name, 0, &errmsg);
rc = sqlite3_load_extension(self->db, extension_name, entrypoint, &errmsg);
if (rc != 0) {
PyErr_SetString(self->OperationalError, errmsg);
return NULL;
Expand Down