Skip to content

gh-102950: Implement PEP 706 – Filter for tarfile.extractall #102953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 16 commits into from
Apr 24, 2023
+1,786 −99
Merged

gh-102950: Implement PEP 706 – Filter for tarfile.extractall #102953

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cde089c
Implement PEP 706 – Filter for tarfile.extractall
encukou Jan 31, 2023
2395c92
Add a blurb
encukou Mar 23, 2023
561a9d4
Remove unneeded backslashes in docs
encukou Mar 27, 2023
54b5644
Fix typos in docs & comments
encukou Mar 27, 2023
7867fc3
Clarify the arguments to register_unpack_format's +function* argument
encukou Mar 27, 2023
734190d
tests: Clean up unused variables and unnecessary f-strings
encukou Mar 27, 2023
d55ae42
Make filter keyword-only in shutil
encukou Apr 6, 2023
c795bb3
Address documentation review
encukou Apr 6, 2023
5d850cc
Fix ReST syntax
encukou Apr 6, 2023
81e9050
Merge main branch to resolve conflict in Whatsnew
encukou Apr 11, 2023
de11090
Remove typo
encukou Apr 11, 2023
b0c0674
Improve errorlevel handling
encukou Apr 18, 2023
3796fdf
Fix the tests to match the PEP update
encukou Apr 19, 2023
08ab551
Document type of errorlevel
encukou Apr 19, 2023
0474842
Skip symlink-related test failures on WASI
encukou Apr 20, 2023
a255634
Ignore unrelated errors in NoneInfoTests_Misc.test_add
encukou Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typos in docs & comments 
Thanks to Ethan for spotting these
  • Loading branch information
@encukou
encukou committed Mar 27, 2023
commit 54b56446f97c8aaf90b66ef4cb7a9d095f751fe2
6 changes: 3 additions & 3 deletions Doc/library/tarfile.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Some facts and figures:

.. versionchanged:: 3.12
Archives are extracted using a :ref:`filter <tarfile-extraction-filter>`,
which makes easy to either limit surprising/dangerous features,
which makes it easy to either limit surprising/dangerous features,
Comment thread
encukou marked this conversation as resolved.
Outdated
or to acknowledge that they are expected and the archive is fully trusted.
By default, archives are fully trusted, but this default is deprecated
Comment thread
gpshead marked this conversation as resolved.
and slated to change in Python 3.14.
Expand Down Expand Up @@ -985,8 +985,8 @@ Here is an incomplete list of things to consider:
etc.).
* Check that filenames have expected extensions (discouraging files that
execute when you “click on them”, or extension-less files like Windows special device names),
Comment thread
encukou marked this conversation as resolved.
Outdated
* Limiting the number of extracted files, total size of extracted data,
filename length (including symlink length), size of individual files.
* Limit the number of extracted files, total size of extracted data,
filename length (including symlink length), and size of individual files.
* Check for files that would be shadowed on case-insensitive filesystems.

Also note that:
Expand Down
2 changes: 1 addition & 1 deletion Lib/shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,7 +1300,7 @@ def unpack_archive(filename, extract_dir=None, format=None, filter=None):

In case none is found, a ValueError is raised.

If `filter` is given, it is passed to he underlying
If `filter` is given, it is passed to the underlying
extraction function.
"""
sys.audit("shutil.unpack_archive", filename, extract_dir, format)
Expand Down