Skip to content

GH-76846, GH-85281: Call __new__() and __init__() on pathlib subclasses #102789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 9 commits into from
Apr 3, 2023
Merged

GH-76846, GH-85281: Call __new__() and __init__() on pathlib subclasses #102789

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3aee8a6
Call `cls.__new__()` from `PurePath._from_parsed_parts()`
barneygale Mar 17, 2023
36f949e
Defer path normalization
barneygale Mar 17, 2023
e54b4cb
Add news blurb.
barneygale Mar 17, 2023
b8842db
Fix `str(Path('foo').parent)`
barneygale Mar 17, 2023
32d13ba
Make pickling cheaper
barneygale Mar 19, 2023
0524417
Revert "Make pickling cheaper"
barneygale Mar 19, 2023
e54a687
Apply suggestions from code review
barneygale Mar 27, 2023
1c155de
Use `object.__new__(cls)` to construct
barneygale Mar 27, 2023
5cc6e13
Tests: use path class to join parts in `_check_parse_parts()`
barneygale Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
  • Loading branch information
@barneygale @zooba
barneygale and zooba authored Mar 27, 2023
commit e54a6872f5cb063d721206ff46db25d07b447e99
8 changes: 4 additions & 4 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ def __truediv__(self, key):

def __rtruediv__(self, key):
try:
return self.__class__(key, self._raw_path)
return type(self)(key, self._raw_path)
except TypeError:
return NotImplemented

Expand Down Expand Up @@ -818,7 +818,7 @@ def absolute(self):
cwd = self._flavour.abspath(self.drive)
else:
cwd = os.getcwd()
return self.__class__(cwd, self._raw_path)
return type(self)(cwd, self._raw_path)

def resolve(self, strict=False):
"""
Expand All @@ -836,7 +836,7 @@ def check_eloop(e):
except OSError as e:
check_eloop(e)
raise
p = self.__class__(s)
p = type(self)(s)

# In non-strict mode, realpath() doesn't raise on symlink loops.
# Ensure we get an exception by calling stat()
Expand Down Expand Up @@ -926,7 +926,7 @@ def readlink(self):
"""
if not hasattr(os, "readlink"):
raise NotImplementedError("os.readlink() not available on this system")
return self.__class__(os.readlink(self))
return type(self)(os.readlink(self))

def touch(self, mode=0o666, exist_ok=True):
"""
Expand Down