Skip to content

gh-102515: Remove unused imports in the Lib/ directory #102516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 4 commits into from
Mar 8, 2023
Merged

gh-102515: Remove unused imports in the Lib/ directory #102516

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a4a4ac
Remove unused imports in the `Lib/` directory
AlexWaygood Mar 7, 2023
a21b7e8
Revert dubious changes to `Lib/concurrent/` and `Lib/multiprocessing/`
AlexWaygood Mar 7, 2023
b3488e8
Make the import in `concurrent/futures/process.py` more explicit
AlexWaygood Mar 7, 2023
4269138
Revert b3488e8, add a comment instead
AlexWaygood Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert b3488e8, add a comment instead
  • Loading branch information
@AlexWaygood
AlexWaygood committed Mar 7, 2023
commit 42691384269df165746aa4884d3a7b2f9c33815c
6 changes: 4 additions & 2 deletions Lib/concurrent/futures/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@
from concurrent.futures import _base
import queue
import multiprocessing as mp
import multiprocessing.connection as mp_connection
# This import is required to load the multiprocessing.connection submodule
# so that it can be accessed later as `mp.connection`
import multiprocessing.connection
from multiprocessing.queues import Queue
import threading
import weakref
Expand Down Expand Up @@ -404,7 +406,7 @@ def wait_result_broken_or_wakeup(self):
wakeup_reader = self.thread_wakeup._reader
readers = [result_reader, wakeup_reader]
worker_sentinels = [p.sentinel for p in list(self.processes.values())]
ready = mp_connection.wait(readers + worker_sentinels)
ready = mp.connection.wait(readers + worker_sentinels)

cause = None
is_broken = True
Expand Down