Skip to content

gh-90110: Fix the c-analyzer Tool #102483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 16 commits into from
Mar 7, 2023
Merged

gh-90110: Fix the c-analyzer Tool #102483

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
71d7bd7
Add Py_BUILD_CORE for some files.
ericsnowcurrently Mar 6, 2023
cf93eb5
Temporarily skip parser-failing files.
ericsnowcurrently Mar 6, 2023
d50cb36
Optionally log the parser depth.
ericsnowcurrently Mar 6, 2023
b94daf7
Fix the GCC directives regex.
ericsnowcurrently Mar 6, 2023
0bc1518
Un-skip some of the files.
ericsnowcurrently Mar 6, 2023
5154513
Fix some ignored variables.
ericsnowcurrently Mar 6, 2023
5d16b2b
Add an ignored variable.
ericsnowcurrently Mar 6, 2023
37948f0
Mark some variables as const.
ericsnowcurrently Mar 6, 2023
0855962
Move last_resort_memory_error to PyInterpreterState.
ericsnowcurrently Mar 6, 2023
688443e
Ignore a few more globals.
ericsnowcurrently Mar 6, 2023
95dddd9
Add a global to the to-fix list.
ericsnowcurrently Mar 6, 2023
9af4fe1
Ignore a global.
ericsnowcurrently Mar 6, 2023
7da3804
Ignore a bunch of test-only globals.
ericsnowcurrently Mar 6, 2023
57f8bb1
Ignore a global.
ericsnowcurrently Mar 6, 2023
332f883
(gcc) __inline__ -> inline
ericsnowcurrently Mar 6, 2023
9f02087
Fix the hash-related modules.
ericsnowcurrently Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix the hash-related modules.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Mar 6, 2023
commit 9f02087992e69c489b87b9c8ee30a0592e1721a1
14 changes: 7 additions & 7 deletions Tools/c-analyzer/cpython/_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,6 @@ def clean_lines(text):
EXCLUDED = clean_lines('''
# @begin=conf@

Modules/_hacl/*.h
Modules/_hacl/*.c
Modules/sha1module.c
Modules/sha2module.c
Modules/md5module.c

# OSX
Modules/_scproxy.c # SystemConfiguration/SystemConfiguration.h

Expand Down Expand Up @@ -111,9 +105,14 @@ def clean_lines(text):
* ./Include
* ./Include/internal

Modules/_decimal/**/*.c Modules/_decimal/libmpdec
Modules/_hacl/*.c Modules/_hacl/include
Modules/_hacl/*.h Modules/_hacl/include
Modules/_tkinter.c /usr/include/tcl8.6
Modules/md5module.c Modules/_hacl/include
Modules/sha1module.c Modules/_hacl/include
Modules/sha2module.c Modules/_hacl/include
Modules/tkappinit.c /usr/include/tcl
Modules/_decimal/**/*.c Modules/_decimal/libmpdec
Objects/stringlib/*.h Objects

# @end=tsv@
Expand Down Expand Up @@ -303,6 +302,7 @@ def clean_lines(text):
# First match wins.
_abs('Modules/_ctypes/ctypes.h'): (5_000, 500),
_abs('Modules/_datetimemodule.c'): (20_000, 300),
_abs('Modules/_hacl/*.c'): (200_000, 500),
_abs('Modules/posixmodule.c'): (20_000, 500),
_abs('Modules/termios.c'): (10_000, 800),
_abs('Modules/_testcapimodule.c'): (20_000, 400),
Expand Down
3 changes: 3 additions & 0 deletions Tools/c-analyzer/cpython/ignored.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,9 @@ Modules/_decimal/_decimal.c - signal_map -
Modules/_decimal/_decimal.c - ssize_constants -
Modules/_elementtree.c - ExpatMemoryHandler -
Modules/_hashopenssl.c - py_hashes -
Modules/_hacl/Hacl_Hash_SHA1.c - _h0 -
Modules/_hacl/Hacl_Hash_MD5.c - _h0 -
Modules/_hacl/Hacl_Hash_MD5.c - _t -
Modules/_io/_iomodule.c - static_types -
Modules/_io/textio.c - encodefuncs -
Modules/_io/winconsoleio.c - _PyWindowsConsoleIO_Type -
Expand Down