Skip to content

gh-102433: Add tests for how classes with properties interact with isinstance() checks on typing.runtime_checkable protocols #102449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 6 commits into from
Mar 11, 2023
Merged

gh-102433: Add tests for how classes with properties interact with isinstance() checks on typing.runtime_checkable protocols #102449

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e32cde9
gh-102433: Add tests for how properties interact with `typing.runtime…
AlexWaygood Mar 5, 2023
74eb795
Don't assert undesirable behaviour; cover other situations too
AlexWaygood Mar 10, 2023
b4ed977
Update Lib/test/test_typing.py
AlexWaygood Mar 10, 2023
14268e5
nit
AlexWaygood Mar 10, 2023
f2bc540
Address review
AlexWaygood Mar 10, 2023
ba178f1
Update Lib/test/test_typing.py
AlexWaygood Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Lib/test/test_typing.py 
Co-authored-by: Carl Meyer <carl@oddbird.net>
  • Loading branch information
@AlexWaygood @carljm
AlexWaygood and carljm authored Mar 11, 2023
commit ba178f1639871525f6dfe2f282c7a0224b712884
2 changes: 1 addition & 1 deletion Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2583,7 +2583,7 @@ class PG1(Protocol[T]):
):
self.assertIsInstance(klass(), protocol_class)

with self.subTest(protocol_class=protocol_class.__name__):
with self.subTest(klass="Empty", protocol_class=protocol_class.__name__):
self.assertNotIsInstance(Empty(), protocol_class)

class BadP(Protocol):
Expand Down