Skip to content

[3.10] Fix unused classes in a typing test (GH-102437) #102442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Mar 5, 2023
Merged

[3.10] Fix unused classes in a typing test (GH-102437) #102442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix unused classes in a typing test (GH-102437) 
As part of investigation issue #102433, I discovered what I believe to be an error where two classes `CI` and `DI` are not being used. The assertions beneath them act on `C` and `D`, duplicating existing assertions in this test.
(cherry picked from commit 7894bbe)

Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com>
Automerge-Triggered-By: GH:AlexWaygood
  • Loading branch information
@JosephSBoyle @miss-islington
JosephSBoyle authored and miss-islington committed Mar 5, 2023
commit 2aa63d7ef2a97df9478e7a40c74b3e1956bd7bcd
4 changes: 2 additions & 2 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,8 +1528,8 @@ class DI:
def __init__(self):
self.x = None

self.assertIsInstance(C(), P)
self.assertIsInstance(D(), P)
self.assertIsInstance(CI(), P)
self.assertIsInstance(DI(), P)

def test_protocols_in_unions(self):
class P(Protocol):
Expand Down