Skip to content

gh-85984: Add POSIX pseudo-terminal functions. #102413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 14 commits into from
Jan 29, 2024
Merged

gh-85984: Add POSIX pseudo-terminal functions. #102413

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
65eb913
Add POSIX pseudo-terminal functions.
8vasu Mar 15, 2023
1e4a6ad
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 15, 2023
bb14261
Merge branch 'main' into posix_pt
8vasu Mar 15, 2023
d2a7fff
Merge branch 'main' into posix_pt
gpshead May 19, 2023
73a3f4e
ReSTify NEWS
gpshead May 19, 2023
c99e91b
versionadded:: 3.12
gpshead May 19, 2023
f6dcd54
Make posix_openpt fd is non-inheritable.
gpshead May 19, 2023
40bad66
Merge in the main branch
encukou Jan 3, 2024
4645976
Update whatsnew version
encukou Jan 3, 2024
efc9482
Add pseudoterminal tests
encukou Jan 8, 2024
3effe4b
Update os.ptsname() so that it uses the C function ptsname_r() if it …
8vasu Jan 20, 2024
2359d1b
Run /Tools/build/regen-configure.sh
8vasu Jan 24, 2024
57acdc3
Docs: Add POSIX C functions to nitpick_ignore
encukou Jan 24, 2024
dd6082c
Merge branch 'main' into posix_pt
encukou Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add pseudoterminal tests
  • Loading branch information
@encukou
encukou committed Jan 8, 2024
commit efc948266ebe6b3cde969bba00ee900f54b5ccf7
36 changes: 30 additions & 6 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4477,13 +4477,37 @@ def test_dup2(self):
self.assertEqual(os.dup2(fd, fd3, inheritable=False), fd3)
self.assertFalse(os.get_inheritable(fd3))

@unittest.skipUnless(hasattr(os, 'openpty'), "need os.openpty()")
@unittest.skipUnless(hasattr(os, 'openpty'), "need os.openpty()")
class PseudoterminalTests(unittest.TestCase):
def open_pty(self):
"""Open a pty fd-pair, and schedule cleanup for it"""
main_fd, second_fd = os.openpty()
self.addCleanup(os.close, main_fd)
self.addCleanup(os.close, second_fd)
return main_fd, second_fd

def test_openpty(self):
master_fd, slave_fd = os.openpty()
self.addCleanup(os.close, master_fd)
self.addCleanup(os.close, slave_fd)
self.assertEqual(os.get_inheritable(master_fd), False)
self.assertEqual(os.get_inheritable(slave_fd), False)
main_fd, second_fd = self.open_pty()
self.assertEqual(os.get_inheritable(main_fd), False)
self.assertEqual(os.get_inheritable(second_fd), False)

@unittest.skipUnless(hasattr(os, 'ptsname'), "need os.ptsname()")
def test_ptsname(self):
main_fd, second_fd = self.open_pty()
self.assertEqual(os.ptsname(main_fd), os.ttyname(second_fd))

@unittest.skipUnless(hasattr(os, 'ptsname'), "need os.ptsname()")
@unittest.skipUnless(hasattr(os, 'grantpt'), "need os.grantpt()")
@unittest.skipUnless(hasattr(os, 'unlockpt'), "need os.unlockpt()")
def test_open_via_ptsname(self):
main_fd, second_fd = self.open_pty()
os.grantpt(main_fd)
os.unlockpt(main_fd)
second_path = os.ptsname(main_fd)
reopened_second_fd = os.open(second_path, os.O_RDWR|os.O_NOCTTY)
self.addCleanup(os.close, reopened_second_fd)
os.write(reopened_second_fd, b'foo')
self.assertEqual(os.read(main_fd, 3), b'foo')


class PathTConverterTests(unittest.TestCase):
Expand Down