Skip to content

bpo-35081: Move Include/pyatomic.c to Include/internal/ #10239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Oct 30, 2018
Merged

bpo-35081: Move Include/pyatomic.c to Include/internal/ #10239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5668fad
bpo-35081: Move Include/pyatomic.c to Include/internal/
vstinner Oct 30, 2018
6061f5b
Address Serhiy's comments
vstinner Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Include/Python.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@
#include "pyport.h"
#include "pymacro.h"

#include "pyatomic.h"

/* Debug-mode build with pymalloc implies PYMALLOC_DEBUG.
* PYMALLOC_DEBUG is in error if pymalloc is not in use.
*/
Expand Down
2 changes: 1 addition & 1 deletion Include/internal/ceval.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
extern "C" {
#endif

#include "pyatomic.h"
#include "internal/pyatomic.h"
#include "pythread.h"

struct _pending_calls {
Expand Down
6 changes: 3 additions & 3 deletions Include/internal/gil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
extern "C" {
#endif

#include "pyatomic.h"

#include "internal/condvar.h"
#include "internal/pyatomic.h"

#ifndef Py_HAVE_CONDVAR
#error You need either a POSIX-compatible or a Windows system!
# error You need either a POSIX-compatible or a Windows system!
#endif

/* Enable if you want to force the switching of threads at least
Expand Down
13 changes: 11 additions & 2 deletions Include/pyatomic.h → Include/internal/pyatomic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
#ifndef Py_ATOMIC_H
#define Py_ATOMIC_H
#ifdef Py_BUILD_CORE
#ifdef __cplusplus
extern "C" {
#endif

#ifndef Py_BUILD_CORE
# error "Py_BUILD_CORE must be defined to include this header"
#endif

#include "dynamic_annotations.h"

Expand Down Expand Up @@ -531,5 +537,8 @@ typedef struct _Py_atomic_int {
_Py_atomic_store_explicit(ATOMIC_VAL, NEW_VAL, _Py_memory_order_relaxed)
#define _Py_atomic_load_relaxed(ATOMIC_VAL) \
_Py_atomic_load_explicit(ATOMIC_VAL, _Py_memory_order_relaxed)
#endif /* Py_BUILD_CORE */

#ifdef __cplusplus
}
#endif
#endif /* Py_ATOMIC_H */
2 changes: 1 addition & 1 deletion Include/internal/pystate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ extern "C" {
#endif

#include "pystate.h"
#include "pyatomic.h"
#include "pythread.h"

#include "internal/mem.h"
#include "internal/ceval.h"
#include "internal/pyatomic.h"
Comment thread
vstinner marked this conversation as resolved.
Outdated
#include "internal/warnings.h"


Expand Down
2 changes: 1 addition & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,6 @@ PYTHON_HEADERS= \
$(srcdir)/Include/pgen.h \
$(srcdir)/Include/pgenheaders.h \
$(srcdir)/Include/pyarena.h \
$(srcdir)/Include/pyatomic.h \
$(srcdir)/Include/pycapsule.h \
$(srcdir)/Include/pyctype.h \
$(srcdir)/Include/pydebug.h \
Expand Down Expand Up @@ -1029,6 +1028,7 @@ PYTHON_HEADERS= \
$(srcdir)/Include/internal/ceval.h \
$(srcdir)/Include/internal/gil.h \
$(srcdir)/Include/internal/mem.h \
$(srcdir)/Include/internal/pyatomic.h \
$(srcdir)/Include/internal/pygetopt.h \
$(srcdir)/Include/internal/pystate.h \
$(srcdir)/Include/internal/context.h \
Expand Down
2 changes: 2 additions & 0 deletions Modules/signalmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
/* XXX Signals should be recorded per thread, now we have thread state. */

#include "Python.h"
#include "internal/pyatomic.h"

#ifndef MS_WINDOWS
#include "posixmodule.h"
#endif
Expand Down
1 change: 1 addition & 0 deletions Python/ceval_gil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include <stdlib.h>
#include <errno.h>

#include "internal/pyatomic.h"

/* First some general settings */

Expand Down