Skip to content

gh-95795: Move types.next_version_tag to PyInterpreterState #102343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 9 commits into from
Apr 24, 2023
Merged

gh-95795: Move types.next_version_tag to PyInterpreterState #102343

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
83e16d5
Move types.next_version_tag to PyInterpreterState for non-core-static…
ericsnowcurrently Feb 28, 2023
c9281e4
Add NEXT_GLOBAL_VERSION_TAG.
ericsnowcurrently Mar 3, 2023
95ffcd1
Handle static types correctly in assign_version_tag().
ericsnowcurrently Mar 3, 2023
f3b707d
Verify that builtin types have builtin bases.
ericsnowcurrently Mar 3, 2023
c32b834
Add an assert.
ericsnowcurrently Mar 3, 2023
6362a36
Do not invalidate the method cache for static builtin types.
ericsnowcurrently Mar 3, 2023
5f8c3e4
Merge branch 'main' into isolate-types-next-version-tag
ericsnowcurrently Apr 24, 2023
0d78c1b
Only use deepfreeze in the main interpreter.
ericsnowcurrently Apr 24, 2023
5e9ec1d
Merge branch 'main' into isolate-types-next-version-tag
ericsnowcurrently Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add an assert.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Mar 3, 2023
commit c32b834c8135ae7f78137309d2cd0d78d22be30b
2 changes: 2 additions & 0 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,9 @@ type_mro_modified(PyTypeObject *type, PyObject *bases) {
}
}
return;

clear:
assert(!(type->tp_flags & _Py_TPFLAGS_STATIC_BUILTIN));
type->tp_flags &= ~Py_TPFLAGS_VALID_VERSION_TAG;
type->tp_version_tag = 0; /* 0 is not a valid version tag */
}
Expand Down