Skip to content

gh-102179: Fix os.dup2() error reporting for negative fds #102180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 3 commits into from
Mar 4, 2023
Merged

gh-102179: Fix os.dup2() error reporting for negative fds #102180

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
411107d
gh-102179: Fix os.dup2() error reporting for negative fds
Feb 23, 2023
01df936
Update Misc/NEWS.d/next/Library/2023-02-23-15-06-01.gh-issue-102179.P…
kumaraditya303 Mar 3, 2023
c32ea70
Skip the test case on Emscripten
Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Skip the test case on Emscripten
  • Loading branch information
Alexey Izbyshev committed Mar 4, 2023
commit c32ea70c904a798d3da2237a0300f676d07a9c56
4 changes: 4 additions & 0 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2222,6 +2222,10 @@ def test_dup2(self):
self.check(os.dup2, 20)

@unittest.skipUnless(hasattr(os, 'dup2'), 'test needs os.dup2()')
@unittest.skipIf(
support.is_emscripten,
"dup2() with negative fds is broken on Emscripten (see gh-102179)"
)
def test_dup2_negative_fd(self):
valid_fd = os.open(__file__, os.O_RDONLY)
self.addCleanup(os.close, valid_fd)
Expand Down