Skip to content

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO #102100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 7 commits into from
Feb 21, 2023
Merged

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO #102100

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5042916
HTTPError fp.read returns string instead of bytes
longvhdeveloper Feb 21, 2023
3553029
update unit test
longvhdeveloper Feb 21, 2023
1de16a7
Update Misc/News.d
longvhdeveloper Feb 21, 2023
d5b74b6
update unit test
longvhdeveloper Feb 21, 2023
b02433e
Update Misc/NEWS.d
longvhdeveloper Feb 21, 2023
9cc1605
Update Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.Q…
corona10 Feb 21, 2023
b1c8dea
Update Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.Q…
corona10 Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Misc/NEWS.d
  • Loading branch information
@longvhdeveloper
longvhdeveloper committed Feb 21, 2023
commit b02433e0b0c72c27bd65aeec0e6763a630f93dba
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
The default value of ``fp`` becomes :class:`io.BytesIO` if :exc:`~urllib.error.HTTPError` is initialized without a designated `fp` parameter. Patch by Long Vo.
The default value of ``fp`` becomes :class:`io.BytesIO` if :exc:`~urllib.error.HTTPError` is initialized without a designated ``fp`` parameter. Patch by Long Vo.
Comment thread
corona10 marked this conversation as resolved.
Outdated