Skip to content

gh-91896: Deprecate collections.abc.ByteString #102096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 13 commits into from
May 4, 2023
Merged

gh-91896: Deprecate collections.abc.ByteString #102096

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
804dfa1
gh-91896: Deprecate collections.abc.ByteString
hauntsaninja Feb 21, 2023
4c7eace
add back a whitespace
hauntsaninja Feb 21, 2023
d534015
docs
hauntsaninja Feb 21, 2023
476a259
typing docs
hauntsaninja Feb 21, 2023
46404a0
pep 688 docs
hauntsaninja Mar 8, 2023
b1b4fd2
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 8, 2023
dc22a74
what's new, removed
hauntsaninja Mar 9, 2023
eeaff44
move to pending removal
hauntsaninja Mar 9, 2023
8777d29
add test
hauntsaninja Mar 11, 2023
c053777
Merge branch 'main' into gh-91896
hauntsaninja Mar 25, 2023
4523ef0
Merge branch 'main' into gh-91896
hauntsaninja Apr 28, 2023
c23e1ad
Merge branch 'main' into gh-91896
AlexWaygood May 4, 2023
f774692
Merge branch 'main' into gh-91896
hugovk May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@hauntsaninja
hauntsaninja committed Mar 11, 2023
commit 8777d294c16fc256544b68122dc96b2624ae8471
4 changes: 4 additions & 0 deletions Lib/test/test_collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1956,6 +1956,10 @@ def test_ByteString(self):
with self.assertWarns(DeprecationWarning):
class X(ByteString): pass

with self.assertWarns(DeprecationWarning):
# No metaclass conflict
class Z(ByteString, Awaitable): pass

def test_MutableSequence(self):
for sample in [tuple, str, bytes]:
self.assertNotIsInstance(sample(), MutableSequence)
Expand Down