Skip to content

gh-101819: Remove _PyWindowsConsoleIO_Type from the Windows DLL #101904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 4 commits into from
Feb 15, 2023
Merged

gh-101819: Remove _PyWindowsConsoleIO_Type from the Windows DLL #101904

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76236f0
gh-101819: Remove _PyWindowsConsoleIO_Type from the Windows DLL
erlend-aasland Feb 14, 2023
8f6ed9d
Pull in main
erlend-aasland Feb 15, 2023
66d43fb
Address review: remove the PyWindowsConsoleIO_Check macro
erlend-aasland Feb 15, 2023
e990468
Copy & paste nitpick
erlend-aasland Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Copy & paste nitpick 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
  • Loading branch information
@erlend-aasland @kumaraditya303
erlend-aasland and kumaraditya303 authored Feb 15, 2023
commit e99046897186c9b3b088587f6f5fc3b15f8cdeed
2 changes: 1 addition & 1 deletion Modules/_io/winconsoleio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ _io__WindowsConsoleIO___init___impl(winconsoleio *self, PyObject *nameobj,
int fd_is_own = 0;
HANDLE handle = NULL;

assert(PyObject_TypeCheck((self), (PyTypeObject *)&PyWindowsConsoleIO_Type));
assert(PyObject_TypeCheck(self, (PyTypeObject *)&PyWindowsConsoleIO_Type));
if (self->fd >= 0) {
if (self->closefd) {
/* Have to close the existing file first. */
Expand Down