Skip to content

gh-101825: mention, that as_integer_ratio() output is normalized #101843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 11 commits into from
Feb 27, 2023
Merged

gh-101825: mention, that as_integer_ratio() output is normalized #101843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d3de603
gh-101825: mention, that as_integer_ratio() output is normalized
skirpichev Feb 12, 2023
dc76383
Update Doc/library/stdtypes.rst
skirpichev Feb 12, 2023
771db87
Slightly adjust above suggestion and do same for the docstring
skirpichev Feb 12, 2023
19738a7
+1 (to cover bool, for instance)
skirpichev Feb 13, 2023
0aeb33a
Lets not test a patience of the reader with examples for this...
skirpichev Feb 13, 2023
f04dc7b
Amend 0aeb33afd4
skirpichev Feb 13, 2023
7892a40
Apply suggestions from code review
skirpichev Feb 27, 2023
c7dcff6
Merge branch 'main' into as_integer_ratio-docs
skirpichev Feb 27, 2023
fdb47d2
Revert int.as_integer_ration() docstring/rst docs to the original patch
skirpichev Feb 27, 2023
31a94d0
Amend d3de6030d4 (correct fractions.rst)
skirpichev Feb 27, 2023
a2a84ae
Amend 7892a40bf4 (same nitpick for float)
skirpichev Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Amend 7892a40 (same nitpick for float)
  • Loading branch information
@skirpichev
skirpichev committed Feb 27, 2023
commit a2a84ae29fa2558590cf5252fae560052426815a
4 changes: 2 additions & 2 deletions Objects/clinic/floatobject.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Objects/floatobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,7 +1548,7 @@ float.as_integer_ratio

Return a pair of integers, whose ratio is exactly equal to the original float.

The ratio is in lowest terms and with a positive denominator. Raise
The ratio is in lowest terms and has a positive denominator. Raise
OverflowError on infinities and a ValueError on NaNs.

>>> (10.0).as_integer_ratio()
Expand All @@ -1561,7 +1561,7 @@ OverflowError on infinities and a ValueError on NaNs.

static PyObject *
float_as_integer_ratio_impl(PyObject *self)
/*[clinic end generated code: output=65f25f0d8d30a712 input=75db3b49d292f077]*/
/*[clinic end generated code: output=65f25f0d8d30a712 input=d5ba7765655d75bd]*/
{
double self_double;
double float_part;
Expand Down