Skip to content

gh-101773: Optimize creation of Fractions in private methods #101780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 13 commits into from
Feb 27, 2023
+50 −34
Merged

gh-101773: Optimize creation of Fractions in private methods #101780

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9cc62f7
gh-101773: Optimize creation of Fraction's in private methods
skirpichev Feb 10, 2023
836d3a6
Merge branch 'main' into opt-fractions-new
skirpichev Feb 10, 2023
3625d34
Adjust signature of _from_pair() and add docstring
skirpichev Feb 11, 2023
9e66b5a
Use new helper in from_float/Decimal
skirpichev Feb 11, 2023
4324391
Restore back _normalize kwarg for the Fraction.__new__()
skirpichev Feb 11, 2023
b0dca38
Amend 3625d34155
skirpichev Feb 11, 2023
3a8506d
Nitpick on docstring (int's -> ints)
skirpichev Feb 27, 2023
13262af
Revert "Restore back _normalize kwarg for the Fraction.__new__()"
skirpichev Feb 27, 2023
4e8977a
Rename: _from_pair -> _from_coprime_ints
skirpichev Feb 27, 2023
57ac373
Merge branch 'main' into opt-fractions-new
skirpichev Feb 27, 2023
4b4a386
Update Misc/NEWS.d/next/Library/2023-02-10-11-59-13.gh-issue-101773.J…
skirpichev Feb 27, 2023
580b1be
+1
skirpichev Feb 27, 2023
53d5e94
Tweak docstring wording
mdickinson Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Restore back _normalize kwarg for the Fraction.__new__()" 
This reverts commit 4324391.
  • Loading branch information
@skirpichev
skirpichev committed Feb 27, 2023
commit 13262af7b792160a5ffec326c7be140afe1dbb40
13 changes: 6 additions & 7 deletions Lib/fractions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class Fraction(numbers.Rational):
__slots__ = ('_numerator', '_denominator')

# We're immutable, so use __new__ not __init__
def __new__(cls, numerator=0, denominator=None, *, _normalize=True):
def __new__(cls, numerator=0, denominator=None):
Comment thread
skirpichev marked this conversation as resolved.
"""Constructs a Rational.

Takes a string like '3/2' or '1.5', another Rational instance, a
Expand Down Expand Up @@ -279,12 +279,11 @@ def __new__(cls, numerator=0, denominator=None, *, _normalize=True):

if denominator == 0:
raise ZeroDivisionError('Fraction(%s, 0)' % numerator)
if _normalize:
g = math.gcd(numerator, denominator)
if denominator < 0:
g = -g
numerator //= g
denominator //= g
g = math.gcd(numerator, denominator)
if denominator < 0:
g = -g
numerator //= g
denominator //= g
self._numerator = numerator
self._denominator = denominator
return self
Expand Down