Skip to content

GH-101362: Optimise pathlib by deferring path normalisation #101560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barneygale wants to merge 16 commits into from
Closed

GH-101362: Optimise pathlib by deferring path normalisation #101560

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b428069
GH-101362 - Optimise pathlib by deferring path normalisation
barneygale Jan 27, 2023
e49e719
Restore str force-casting behaviour; reduce diff a little.
barneygale Feb 4, 2023
a931986
Fix pathlib usage error in importlib
barneygale Feb 4, 2023
38f70bf
Improve initialiser performance.
barneygale Feb 4, 2023
10844a6
Add NEWS blurb
barneygale Feb 4, 2023
d5231b6
Store '_fspath' as non-empty string.
barneygale Feb 4, 2023
76b2db7
Merge branch 'main' into optimize-pathlib-part-2b
barneygale Mar 6, 2023
cc2c711
Undo addition of `__init__()` and change to `_from_parsed_parts()`
barneygale Mar 6, 2023
cbf0fcd
Fix pickling of paths created via walking.
barneygale Mar 6, 2023
eb7087f
Simplify patch slightly
barneygale Mar 6, 2023
3b53e27
Remove unused import
barneygale Mar 11, 2023
dec98f2
Merge branch 'main' into optimize-pathlib-part-2b
barneygale Mar 11, 2023
d9a6080
Fix dodgy merge, add comment about _from_parsed_parts()
barneygale Mar 11, 2023
9650dca
Stop returning unnormalised path from `__fspath__()`
barneygale Mar 17, 2023
af27476
Merge branch 'main' into optimize-pathlib-part-2b
barneygale Mar 17, 2023
97995bd
Undo change to `joinpath()`, fix news blurb.
barneygale Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify patch slightly
  • Loading branch information
@barneygale
barneygale committed Mar 6, 2023
commit eb7087f7a9f44823071559ba363c8cd0579a1981
14 changes: 5 additions & 9 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,9 @@ def __reduce__(self):
return (self.__class__, self.parts)

@classmethod
def _join_parts(cls, parts):
def _from_parts(cls, parts):
if not parts:
return ''
path = ''
elif len(parts) == 1:
path = os.fspath(parts[0])
else:
Expand All @@ -287,7 +287,9 @@ def _join_parts(cls, parts):
"argument should be a str or an os.PathLike "
"object where __fspath__ returns a str, "
f"not {type(path).__name__!r}")
return path
self = object.__new__(cls)
self._fspath = path
return self

@classmethod
def _parse_path(cls, path):
Expand All @@ -305,12 +307,6 @@ def _parse_path(cls, path):
parsed = [sys.intern(x) for x in unfiltered_parsed if x and x != '.']
return drv, root, parsed

@classmethod
def _from_parts(cls, args):
self = object.__new__(cls)
self._fspath = cls._join_parts(args)
return self

def _load_parts(self):
drv, root, parts = self._parse_path(self._fspath)
self._drv = drv
Expand Down