Skip to content

gh-101384: add socket timeout to ThreadedVSOCKSocketStreamTest and skip it on WSL #101418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterjpxie wants to merge 3 commits into from
Closed

gh-101384: add socket timeout to ThreadedVSOCKSocketStreamTest and skip it on WSL #101418

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69c254b
1/ Add socket timeout to ThreadedVSOCKSocketStreamTest to consider te…
Jan 30, 2023
fb5f724
remove temp file test_socket2.py
Jan 30, 2023
ae6f5fc
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
1/ Add socket timeout to ThreadedVSOCKSocketStreamTest to consider te… 
…st failure. 2/ Skip ThreadedVSOCKSocketStreamTest on WSL.
  • Loading branch information
peter authored and peter committed Jan 30, 2023
commit 69c254ba2334d601a5db29d7110371d2dc5a66e5
3 changes: 3 additions & 0 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@

VSOCKPORT = 1234
AIX = platform.system() == "AIX"
WSL = "microsoft-standard-WSL" in platform.release()

try:
import _socket
Expand Down Expand Up @@ -498,6 +499,7 @@ def clientTearDown(self):
ThreadableTest.clientTearDown(self)

@unittest.skipIf(fcntl is None, "need fcntl")
@unittest.skipIf(WSL, 'VSOCK does not work on Microsoft WSL')
@unittest.skipUnless(HAVE_SOCKET_VSOCK,
'VSOCK sockets required for this test.')
@unittest.skipUnless(get_cid() != 2,
Expand All @@ -514,6 +516,7 @@ def setUp(self):
self.serv.bind((socket.VMADDR_CID_ANY, VSOCKPORT))
self.serv.listen()
self.serverExplicitReady()
self.serv.settimeout(support.LOOPBACK_TIMEOUT)
self.conn, self.connaddr = self.serv.accept()
self.addCleanup(self.conn.close)

Expand Down
Loading