Skip to content

GH-100288: Skip extra work when failing to specialize LOAD_ATTR #101354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 2 commits into from
Jan 31, 2023
Merged

GH-100288: Skip extra work when failing to specialize LOAD_ATTR #101354

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6dcb34
Remove old branch
brandtbucher Jan 17, 2023
b1845b6
Simplify method load specialization
brandtbucher Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove old branch
  • Loading branch information
@brandtbucher
brandtbucher committed Jan 17, 2023
commit d6dcb34303f560b1c9d89ca8ff9be3414c08171b
2 changes: 1 addition & 1 deletion Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ PyObject *descr, DescriptorClassification kind)
}
}
}
if (dictkind == MANAGED_VALUES || dictkind == OFFSET_DICT) {
if (dictkind == MANAGED_VALUES) {
Copy link
Copy Markdown
Member

@markshannon markshannon Jan 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is only the one case now, it would make the code easier to follow if this were moved into the case MANAGED_VALUES: below.

Py_ssize_t index = _PyDictKeys_StringLookup(keys, name);
if (index != DKIX_EMPTY) {
SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_SHADOWED);
Expand Down