Skip to content

GH-92123: Pass _elementtree state as parameter #101189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 11 commits into from
Jan 24, 2023
+73 −57
Merged

GH-92123: Pass _elementtree state as parameter #101189

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
636c7fa
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
065bcb6
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
de344e1
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
a85276e
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
ac623de
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
b7827db
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
8043112
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
53bd559
Refactor: replace query with parameter
erlend-aasland Jan 22, 2023
706385a
Refactor: replace query with parameter
erlend-aasland Jan 20, 2023
0195c35
Fix cherry-picks
erlend-aasland Jan 20, 2023
8e1e070
Apply PEP 7 to affected lines
erlend-aasland Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor: replace query with parameter 
Pass state as arg to create_elementiter()
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jan 23, 2023
commit ac623de963ff45fb580764a534b8aae3c1a0d511
13 changes: 8 additions & 5 deletions Modules/_elementtree.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,7 +1391,8 @@ _elementtree_Element_get_impl(ElementObject *self, PyObject *key,
}

static PyObject *
create_elementiter(ElementObject *self, PyObject *tag, int gettext);
create_elementiter(elementtreestate *st, ElementObject *self, PyObject *tag,
int gettext);


/*[clinic input]
Expand All @@ -1416,7 +1417,8 @@ _elementtree_Element_iter_impl(ElementObject *self, PyObject *tag)
tag = Py_None;
}

return create_elementiter(self, tag, 0);
elementtreestate *st = ET_STATE_GLOBAL;
return create_elementiter(st, self, tag, 0);
}


Expand All @@ -1429,7 +1431,8 @@ static PyObject *
_elementtree_Element_itertext_impl(ElementObject *self)
/*[clinic end generated code: output=5fa34b2fbcb65df6 input=af8f0e42cb239c89]*/
{
return create_elementiter(self, Py_None, 1);
elementtreestate *st = ET_STATE_GLOBAL;
return create_elementiter(st, self, Py_None, 1);
}


Expand Down Expand Up @@ -2247,11 +2250,11 @@ static PyType_Spec elementiter_spec = {
#define INIT_PARENT_STACK_SIZE 8

static PyObject *
create_elementiter(ElementObject *self, PyObject *tag, int gettext)
create_elementiter(elementtreestate *st, ElementObject *self, PyObject *tag,
int gettext)
{
ElementIterObject *it;

elementtreestate *st = ET_STATE_GLOBAL;
it = PyObject_GC_New(ElementIterObject, st->ElementIter_Type);
if (!it)
return NULL;
Expand Down