Skip to content

[WIP] Various build system improvements #101093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
indygreg wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[WIP] Various build system improvements #101093

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8eb0b50
gh-104523: inline minimal PGO rules
indygreg Jan 16, 2023
f215844
gh-xxxx: overhaul build rules for optimized binaries
indygreg Jan 16, 2023
c8759fd
gh-xxxx: move BOLT arguments to configure
indygreg Jan 16, 2023
02418fd
gh-xxxx: run BOLT instrumented binary with `$(RUNSHARED)`
indygreg Jan 16, 2023
a212332
gh-xxxx: enable BOLT optimization of libpython
indygreg Jan 16, 2023
9e50ee0
gh-xxxx: expose _PYTHON_HOST_PLATFORM as a settable variable
indygreg Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-xxxx: run BOLT instrumented binary with $(RUNSHARED) 
This ensures `LD_LIBRARY_PATH` is set. Without this, I was able to
tickle a libpythonX.Y.so not found error.
  • Loading branch information
@indygreg
indygreg committed May 16, 2023
commit 02418fde929452e3fdddc76bf6d5aa620c0ad04b
2 changes: 1 addition & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ profile-bolt-instrument-stamp: profile-bolt-prebuild-stamp
touch $@

profile-bolt-run-stamp: profile-bolt-instrument-stamp
./$(BUILDPYTHON).bolt_inst $(PROFILE_TASK) || true
$(RUNSHARED) ./$(BUILDPYTHON).bolt_inst $(PROFILE_TASK) || true
touch $@

profile-bolt-analyze-stamp: profile-bolt-run-stamp
Expand Down