Skip to content

gh-100690: Prevent prefix "called_" for attributes of safe mock objects #100691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjw296 merged 6 commits into from
Jan 6, 2023
Merged

gh-100690: Prevent prefix "called_" for attributes of safe mock objects #100691

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
154012f
Prevent calling assert functions without the prefix "assert_" in safe…
cklein Jan 3, 2023
26dc793
Merge remote-tracking branch 'python/main' into disallow_mock_method_…
cklein Jan 5, 2023
2bd97a1
Added tests to show that names from denylist still can be used with a…
cklein Jan 5, 2023
01946cb
Changed documentation
cklein Jan 6, 2023
e9b8f73
Reformatted NEWS
cklein Jan 6, 2023
674f5bc
Merge branch 'main' into disallow_mock_method_prefix
cjw296 Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reformatted NEWS
  • Loading branch information
@cklein
cklein committed Jan 6, 2023
commit e9b8f739a5790a8c4a7b9110a23ae70c1d76ffe8
10 changes: 7 additions & 3 deletions Misc/NEWS.d/next/Library/2023-01-02-16-59-49.gh-issue-100690.2EgWPS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Mock objects which are not unsafe will now raise an AttributeError when accessing an
attribute that matches the name of an assertion but without the prefix ``assert_``, e.g. accessing ``called_once`` instead of ``assert_called_once``.
This is in addition to this already happening for accessing attributes with prefixes assert, assret, asert, aseert, and assrt.
``Mock`` objects which are not unsafe will now raise an
``AttributeError`` when accessing an attribute that matches the name
of an assertion but without the prefix ``assert_``, e.g. accessing
``called_once`` instead of ``assert_called_once``.
This is in addition to this already happening for accessing attributes
with prefixes ``assert``, ``assret``, ``asert``, ``aseert``,
and ``assrt``.