Skip to content

gh-78997: fix bad rebase of moved test file #100424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FFY00 merged 1 commit into from
Dec 22, 2022
+6 −188
Merged

gh-78997: fix bad rebase of moved test file #100424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-25177: fix bad rebase of moved test file 
During the process of merging in a year and a half of changes, the
modified test file `test_loading.py` accidentally got converted to a
newly added file in an old location, rather than an existing test file
with an updated test.

Merge the changes in this file into the new canonical location since
gh-93839, and delete the old file.
  • Loading branch information
@eli-schwartz
eli-schwartz committed Dec 22, 2022
commit 1ff6ee3b9fbd0a4ce499f28385b8dc182f391e17
188 changes: 0 additions & 188 deletions Lib/ctypes/test/test_loading.py
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions Lib/test/test_ctypes/test_loading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,12 @@ def test_1703286_B(self):
# This is the real test: call the function via 'call_function'
self.assertEqual(0, call_function(proc, (None,)))

@unittest.skipUnless(os.name == "nt",
'test specific to Windows')
def test_load_hasattr(self):
# bpo-34816: shouldn't raise OSError
self.assertFalse(hasattr(windll, 'test'))

@unittest.skipUnless(os.name == "nt",
'test specific to Windows')
def test_load_dll_with_flags(self):
Expand Down