Skip to content

gh-100344: Provide C implementation for asyncio.current_task #100345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 11 commits into from
Dec 22, 2022
Merged

gh-100344: Provide C implementation for asyncio.current_task #100345

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
76cbbc6
gh-100344: Provide C implementation for asyncio.current_task
itamaro Sep 18, 2022
c7af32b
Merge branch 'main' into asyncio-current-task-native-impl
itamaro Dec 20, 2022
5f33beb
Fix refleak in C impl of current_task
itamaro Dec 20, 2022
37072a1
Optimize also the common case of the Python implementation of asyncio…
itamaro Dec 20, 2022
5a8a8fd
Merge branch 'main' into asyncio-current-task-native-impl
itamaro Dec 20, 2022
8f0f80a
Catch more specific KeyError exception
itamaro Dec 21, 2022
04bf985
Merge branch 'main' into asyncio-current-task-native-impl
itamaro Dec 21, 2022
637dfa7
Merge branch 'main' into asyncio-current-task-native-impl
itamaro Dec 21, 2022
c96db2c
Adjust CurrentLoopTests to cover both C and Python implementations of…
itamaro Dec 21, 2022
bdeb553
Merge branch 'main' into asyncio-current-task-native-impl
itamaro Dec 22, 2022
391db59
Revert optimizations in Python implementation of asyncio.current_task
itamaro Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust CurrentLoopTests to cover both C and Python implementations of… 
… current_task
  • Loading branch information
@itamaro
itamaro committed Dec 21, 2022
commit c96db2c3073f1366e51aa17d924ad9ad8b4a7264
21 changes: 14 additions & 7 deletions Lib/test/test_asyncio/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2804,6 +2804,7 @@ class CIntrospectionTests(test_utils.TestCase, BaseTaskIntrospectionTests):


class BaseCurrentLoopTests:
current_task = None

def setUp(self):
super().setUp()
Expand All @@ -2814,33 +2815,39 @@ def new_task(self, coro):
raise NotImplementedError

def test_current_task_no_running_loop(self):
self.assertIsNone(asyncio.current_task(loop=self.loop))
self.assertIsNone(self.current_task(loop=self.loop))

def test_current_task_no_running_loop_implicit(self):
with self.assertRaisesRegex(RuntimeError, 'no running event loop'):
asyncio.current_task()
self.current_task()

def test_current_task_with_implicit_loop(self):
async def coro():
self.assertIs(asyncio.current_task(loop=self.loop), task)
self.assertIs(self.current_task(loop=self.loop), task)

self.assertIs(asyncio.current_task(None), task)
self.assertIs(asyncio.current_task(), task)
self.assertIs(self.current_task(None), task)
self.assertIs(self.current_task(), task)

task = self.new_task(coro())
self.loop.run_until_complete(task)
self.assertIsNone(asyncio.current_task(loop=self.loop))
self.assertIsNone(self.current_task(loop=self.loop))


class PyCurrentLoopTests(BaseCurrentLoopTests, test_utils.TestCase):
current_task = staticmethod(tasks._py_current_task)

def new_task(self, coro):
return tasks._PyTask(coro, loop=self.loop)


@unittest.skipUnless(hasattr(tasks, '_CTask'),
@unittest.skipUnless(hasattr(tasks, '_CTask') and
hasattr(tasks, '_c_current_task'),
'requires the C _asyncio module')
class CCurrentLoopTests(BaseCurrentLoopTests, test_utils.TestCase):
if hasattr(tasks, '_c_current_task'):
current_task = staticmethod(tasks._c_current_task)
else:
current_task = None

def new_task(self, coro):
return getattr(tasks, '_CTask')(coro, loop=self.loop)
Expand Down