Skip to content

gh-100305: Deemphasize that ast.literal_eval is safe in eval documentation #100326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 6 commits into from
Apr 12, 2026
Merged

gh-100305: Deemphasize that ast.literal_eval is safe in eval documentation #100326

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
45e57be
changed the doc for literal_eval in eval
ramvikrams Dec 17, 2022
c05387b
Update functions.rst
ramvikrams Dec 17, 2022
da1f416
Update functions.rst
ramvikrams Dec 18, 2022
d05eacc
Update functions.rst
ramvikrams Dec 20, 2022
e388fd4
don't scare quotes safely, just say to
gpshead Apr 12, 2026
f6d3883
Merge branch 'main' into t12
gpshead Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update functions.rst
  • Loading branch information
@ramvikrams
ramvikrams committed Dec 17, 2022
commit c05387bcc10ae8e405a8217f5c149091f0ec32d3
6 changes: 3 additions & 3 deletions Doc/library/functions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,9 @@ are always available. They are listed here in alphabetical order.
If the given source is a string, then leading and trailing spaces and tabs
are stripped.

.. versionchanged:: 3.11
:func:`ast.literal_eval` is no longer marked as safe for evaluating strings
with expressions containing only literals. For further information, please
.. versionchanged:: 3.11
Copy link
Copy Markdown
Contributor

@slateny slateny Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about saying 'version changed', as it seems to imply that only 3.11 has the change, but 3.10 also has it as it was backported (see PR). I'd say it's okay to just keep the original format and adjust the wording.

Copy link
Copy Markdown
Contributor Author

@ramvikrams ramvikrams Dec 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

:func:`ast.literal_eval` is no longer marked as safe for evaluating strings
with expressions containing only literals. For further information, please
check the documentation for :func:`ast.literal_eval`

.. audit-event:: exec code_object eval
Expand Down