bpo-35027: Correct 3.7 meta-data changes in setup.py documentation. - #10032
Merged
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Member
|
LGTM. I hope the CLA will be processed in a couple of days so that a core dev can look into this. Thanks for the PR :) |
Contributor
|
GH-10084 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2018
….7 (pythonGH-10032) (cherry picked from commit e80e77a) Co-authored-by: TilmanK <tilman.krummeck@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the setup.py user documentation to reflect the changes made in 8837dd0#diff-d9afd486aff62306cb23cb8be2d4458eR30.
Distutils will only warn when something else than a list or str is used, but not raise a TypeError explicitly. It will even convert the given value to a list if possible (i.e. for a tuple).. Therefore, I removed the passage about the TypeError replacing it with the hint about the new warning.
https://bugs.python.org/issue35027