Skip to content

Better stats for LOAD_ATTR and STORE_ATTR #100295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 3 commits into from
Dec 16, 2022
Merged

Better stats for LOAD_ATTR and STORE_ATTR #100295

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db9f04f
Don't attempt to specialize for LOAD_ATTR on instance if class has at…
markshannon Dec 16, 2022
31ad53e
Further improvement to LOAD_ATTR and STORE_ATTR specialization stats.
markshannon Dec 16, 2022
05a9952
Refine stats for LOAD_ATTR with class attribute.
markshannon Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't attempt to specialize for LOAD_ATTR on instance if class has at… 
…tribute, improve stats.
  • Loading branch information
@markshannon
markshannon committed Dec 16, 2022
commit db9f04f17a7fa9ee794adb9e8ccdd4a24a8547b3
16 changes: 10 additions & 6 deletions Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ _PyCode_Quicken(PyCodeObject *code)
#define SPEC_FAIL_ATTR_PROPERTY_NOT_PY_FUNCTION 28
#define SPEC_FAIL_ATTR_NOT_IN_KEYS 29
#define SPEC_FAIL_ATTR_NOT_IN_DICT 30
#define SPEC_FAIL_ATTR_CLASS_ATTR 31

/* Binary subscr and store subscr */

Expand Down Expand Up @@ -814,15 +815,18 @@ _Py_Specialize_LoadAttr(PyObject *owner, _Py_CODEUNIT *instr, PyObject *name)
}
case BUILTIN_CLASSMETHOD:
case PYTHON_CLASSMETHOD:
SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_CLASS_METHOD_OBJ);
goto fail;
case NON_OVERRIDING:
case NON_DESCRIPTOR:
SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_CLASS_ATTR);
goto fail;
case ABSENT:
break;
}
if (specialize_dict_access(owner, instr, type, kind, name, LOAD_ATTR,
LOAD_ATTR_INSTANCE_VALUE, LOAD_ATTR_WITH_HINT))
{
goto success;
if (specialize_dict_access(owner, instr, type, kind, name, LOAD_ATTR,
LOAD_ATTR_INSTANCE_VALUE, LOAD_ATTR_WITH_HINT))
{
goto success;
}
}
fail:
STAT_INC(LOAD_ATTR, failure);
Expand Down