Skip to content

GH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP #100278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 5 commits into from
Dec 16, 2022
Merged

GH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP #100278

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0728cf
Handle NaNs in COMPARE_OP_FLOAT_JUMP
brandtbucher Nov 28, 2022
2665c9a
Remove NaN checks!
brandtbucher Nov 30, 2022
dba5894
Catch up with main
brandtbucher Nov 30, 2022
66d2d63
Catch up with main
brandtbucher Dec 15, 2022
9dc68aa
blurb add
brandtbucher Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Catch up with main
  • Loading branch information
@brandtbucher
brandtbucher committed Dec 15, 2022
commit 66d2d6305200c800241ae1ba1c9cd0d969abd0e9
2 changes: 1 addition & 1 deletion Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1996,7 +1996,7 @@ _Py_Specialize_CompareOp(PyObject *lhs, PyObject *rhs, _Py_CODEUNIT *instr,
goto failure;
}
else {
_Py_SET_OPCODE(*instr, COMPARE_OP_STR_JUMP);
_py_set_opcode(instr, COMPARE_OP_STR_JUMP);
cache->mask = (when_to_jump_mask & 8) == 0;
goto success;
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.