Skip to content

gh-83076: 3.8x speed improvement in (Async)Mock instantiation #100252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjw296 merged 9 commits into from
Dec 23, 2022
Merged

gh-83076: 3.8x speed improvement in (Async)Mock instantiation #100252

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8a2a39f
gh-83076: ~4x speed improvement in (Async)Mock instantiation
carljm Dec 14, 2022
7a30565
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 14, 2022
597209d
Remove redundant AsyncMagicMixin.__init__ method
carljm Dec 14, 2022
246772c
Fix rst syntax in news blurb
carljm Dec 14, 2022
2260a54
Merge branch 'main' into fastmock
carljm Dec 16, 2022
a03f843
fix instance-only async attr
carljm Dec 16, 2022
1b6241a
Merge branch 'main' into fastmock
carljm Dec 16, 2022
6595272
determine spec shape only at mock construction time
carljm Dec 16, 2022
a9af20a
Merge branch 'main' into fastmock
carljm Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant AsyncMagicMixin.__init__ method
  • Loading branch information
@carljm
carljm committed Dec 14, 2022
commit 597209dd488d846acee5432bec6a8d1f4654566f
6 changes: 2 additions & 4 deletions Lib/unittest/mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,10 +2133,8 @@ def mock_add_spec(self, spec, spec_set=False):


class AsyncMagicMixin(MagicMixin):
def __init__(self, /, *args, **kw):
self._mock_set_magics() # make magic work for kwargs in init
_safe_super(AsyncMagicMixin, self).__init__(*args, **kw)
self._mock_set_magics() # fix magic broken by upper level init
pass


class MagicMock(MagicMixin, Mock):
"""
Expand Down