Skip to content

GH-100192: add more asyncio subprocess tests #100194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 5 commits into from
Dec 28, 2022
Merged

GH-100192: add more asyncio subprocess tests #100194

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9d044b
add tests
kumaraditya303 Dec 12, 2022
1d96bf7
fix tests on windows
kumaraditya303 Dec 12, 2022
d75002c
Merge branch 'main' of https://github.com/python/cpython into subproc…
kumaraditya303 Dec 22, 2022
cb694ed
compare entire list
kumaraditya303 Dec 22, 2022
0a46c45
refactor to helper
kumaraditya303 Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests on windows
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Dec 12, 2022
commit 1d96bf75e78d83e995516bd4871691686328968e
8 changes: 4 additions & 4 deletions Lib/test/test_asyncio/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,13 +688,13 @@ async def execute():

def test_create_subprocess_env_shell(self) -> None:
async def main() -> None:
cmd = f'''{sys.executable} -c "import os; print(os.getenv('FOO'))"'''
cmd = f'''{sys.executable} -c "import os, sys; sys.stdout.write(os.getenv('FOO'))"'''
env = {"FOO": 'bar'}
proc = await asyncio.create_subprocess_shell(
cmd, env=env, stdout=subprocess.PIPE
)
stdout, _ = await proc.communicate()
self.assertEqual(stdout, b"bar\n")
self.assertEqual(stdout, b"bar")
self.assertEqual(proc.returncode, 0)
task = asyncio.create_task(proc.wait())
await asyncio.sleep(0)
Expand All @@ -705,13 +705,13 @@ async def main() -> None:
def test_create_subprocess_env_exec(self) -> None:
async def main() -> None:
cmd = [sys.executable, "-c",
"import os; print(os.getenv('FOO'))"]
"import os, sys; sys.stdout.write(os.getenv('FOO'))"]
env = {"FOO": 'bar'}
proc = await asyncio.create_subprocess_exec(
*cmd, env=env, stdout=subprocess.PIPE
)
stdout, _ = await proc.communicate()
self.assertEqual(stdout, b"bar\n")
self.assertEqual(stdout, b"bar")
self.assertEqual(proc.returncode, 0)
task = asyncio.create_task(proc.wait())
await asyncio.sleep(0)
Expand Down