Skip to content

GH-100133: fix asyncio subprocess losing stderr and stdout output #100154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 9 commits into from
Dec 21, 2022
Merged

GH-100133: fix asyncio subprocess losing stderr and stdout output #100154

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b980b7f
wip
kumaraditya303 Dec 10, 2022
6b9d8c1
add comment & test
kumaraditya303 Dec 10, 2022
af1d4e6
fix comment
kumaraditya303 Dec 10, 2022
6b87ae7
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 10, 2022
3f55f14
use sys.executable
kumaraditya303 Dec 10, 2022
2427537
Merge branch 'main' of https://github.com/python/cpython into fix-sub…
kumaraditya303 Dec 12, 2022
4a55951
fix news
kumaraditya303 Dec 12, 2022
6371452
fix import
kumaraditya303 Dec 12, 2022
e9c8fce
remove redundant code
kumaraditya303 Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
wip
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Dec 10, 2022
commit b980b7f1078232efba5ee55baf5c2e05f9784f60
8 changes: 5 additions & 3 deletions Lib/asyncio/base_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,11 @@ def _process_exited(self, returncode):
# object. On Python 3.6, it is required to avoid a ResourceWarning.
self._proc.returncode = returncode
self._call(self._protocol.process_exited)
for p in self._pipes.values():
if p is not None:
p.pipe.close()
# The pipes should not be closed otherwise some data may be lost.
# https://github.com/python/cpython/issues/100133
# for p in self._pipes.values():
# if p is not None:
# p.pipe.close()
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated

self._try_finish()

Expand Down
15 changes: 15 additions & 0 deletions Lib/test/test_asyncio/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,21 @@ async def execute():

self.assertIsNone(self.loop.run_until_complete(execute()))

def test_subprocess_output_stdout(self):
async def get_command_stdout(cmd, *args):
proc = await asyncio.create_subprocess_exec(
cmd, *args, stdout=asyncio.subprocess.PIPE,
)
stdout, _ = await proc.communicate()
return stdout.decode().strip()

async def main():
outputs = [f'foo{i}' for i in range(10)]
Comment thread
gvanrossum marked this conversation as resolved.
res = await asyncio.gather(*[get_command_stdout('echo', out) for out in outputs])
self.assertEqual(res, outputs)

self.loop.run_until_complete(main())


if sys.platform != 'win32':
# Unix
Expand Down