Skip to content

gh-100143: Improve collecting pystats for parts of runs #100144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 7 commits into from
Dec 12, 2022
Merged

gh-100143: Improve collecting pystats for parts of runs #100144

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
153e33e
pystats off by default
mdboom Dec 9, 2022
63eb983
Add -Xpystats flag
mdboom Dec 9, 2022
fcabb09
Always dump pystats, even if turned off
mdboom Dec 9, 2022
66facd6
Fix division-by-zero errors in summarize_stats.py
mdboom Dec 9, 2022
73af144
Add blurb
mdboom Dec 9, 2022
07dcbad
Update Misc/NEWS.d/next/Core and Builtins/2022-12-09-14-27-36.gh-issu…
mdboom Dec 12, 2022
efa0bb6
Merge branch 'main' into fix-pystats
mdboom Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always dump pystats, even if turned off
  • Loading branch information
@mdboom
mdboom committed Dec 9, 2022
commit fcabb09d8e019a200ab31be2ebdb4d0cf0581eb2
5 changes: 1 addition & 4 deletions Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,6 @@ _Py_StatsClear(void)
void
_Py_PrintSpecializationStats(int to_file)
{
if (_py_stats == NULL) {
return;
}
FILE *out = stderr;
if (to_file) {
/* Write to a file instead of stderr. */
Expand Down Expand Up @@ -238,7 +235,7 @@ _Py_PrintSpecializationStats(int to_file)
else {
fprintf(out, "Specialization stats:\n");
}
print_stats(out, _py_stats);
print_stats(out, &_py_stats_struct);
if (out != stderr) {
fclose(out);
}
Expand Down