Skip to content

GH-100112: avoid using iterable coroutines in asyncio internally #100128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 5 commits into from
Mar 16, 2023
Merged

GH-100112: avoid using iterable coroutines in asyncio internally #100128

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6492e9
add wrapper
kumaraditya303 Dec 9, 2022
7fecb6f
inline it
kumaraditya303 Mar 10, 2023
89524c5
add test
kumaraditya303 Mar 10, 2023
046458f
fix tests
kumaraditya303 Mar 10, 2023
dddb7bd
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Mar 10, 2023
commit 046458fb9f93f1b41fe2038f6bee82857d770894
9 changes: 3 additions & 6 deletions Lib/asyncio/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,17 +634,14 @@ def ensure_future(coro_or_future, *, loop=None):
raise ValueError('The future belongs to a different loop than '
'the one specified as the loop argument')
return coro_or_future
should_close = False
should_close = True
if not coroutines.iscoroutine(coro_or_future):
if inspect.isawaitable(coro_or_future):
async def _wrap_awaitable(awaitable):
@types.coroutine
def wrapper():
return (yield from awaitable.__await__())
return await wrapper()
return await awaitable

coro_or_future = _wrap_awaitable(coro_or_future)
should_close = True
should_close = False
else:
raise TypeError('An asyncio.Future, a coroutine or an awaitable '
'is required')
Expand Down