Skip to content

Support "bpo-" in Misc/NEWS #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zware merged 3 commits into from
Feb 10, 2017
+4 −4
Merged

Support "bpo-" in Misc/NEWS #1

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1900740
Support "bpo-" in Misc/NEWS
brettcannon Feb 10, 2017
5401164
Fix up the match and substitution regexes
brettcannon Feb 10, 2017
02a87ce
Address reviewer comments
brettcannon Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix up the match and substitution regexes 
Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.
  • Loading branch information
@brettcannon
brettcannon authored Feb 10, 2017
commit 54011640183be0f18eebe2da7b0e3e81160dbb17
4 changes: 2 additions & 2 deletions Doc/tools/extensions/pyspecific.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def run(self):

# Support for including Misc/NEWS

issue_re = re.compile('([Ii]ssue #|bpo-)([0-9]+)')
issue_re = re.compile('(?:[Ii]ssue #|bpo-)([0-9]+)')
whatsnew_re = re.compile(r"(?im)^what's new in (.*?)\??$")


Expand Down Expand Up @@ -253,7 +253,7 @@ def run(self):
text = 'The NEWS file is not available.'
node = nodes.strong(text, text)
return [node]
content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__',
content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__',
Copy link
Copy Markdown
Member

@zware zware Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest making it https://bugs.python.org/issue\1 to avoid the redirect through https://www.python.org/sf/

Copy link
Copy Markdown
Member Author

@brettcannon brettcannon Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

content)
content = whatsnew_re.sub(r'\1', content)
# remove first 3 lines as they are the main heading
Expand Down