Skip to content

Remove check for stdarg.h (HAVE_STDARG_PROTOTYPES) in configure.ac #93207

Closed

Description

@kumaraditya303

CPython checks for stdarg.h as HAVE_STDARG_PROTOTYPES 1 at some places 2 but not at other places 3. Either this check should be repeated at every call site or should be removed all together, most compilers supports this nowadays (should be verified with buildbots).

cc @vstinner @tiran @erlend-aasland

Footnotes

  1. https://github.com/python/cpython/blob/16a7e4a0b75080275bf12cfb71d54b01d85099b2/configure.ac#L5026 ↩

  2. https://github.com/python/cpython/blob/16a7e4a0b75080275bf12cfb71d54b01d85099b2/Modules/_asynciomodule.c#L2646 ↩

  3. https://github.com/python/cpython/blob/16a7e4a0b75080275bf12cfb71d54b01d85099b2/Objects/call.c#L557 ↩

Activity

  1. vstinner commented on May 25, 2022

    @vstinner
    Member

    Do you want to propose a PR for that?

  2. kumaraditya303 commented on May 25, 2022

    @kumaraditya303
    ContributorAuthor

    Created PR #93215

  3. added a commit that references this issue on May 27, 2022
  4. erlend-aasland commented on Jun 2, 2022

    @erlend-aasland
    Contributor

    [...] most compilers supports this nowadays

    As pointed out in cython/cython#4820, this may change in the future:

    https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2975.pdf

  5. h-vetinari commented on Nov 7, 2022

    @h-vetinari
    Contributor

    As pointed out in cython/cython#4820, this may change in the future:

    https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2975.pdf

    Bit late, but JFYI, this paper got accepted into C23.

    Edit: sorry for the double-post; GH bugging with server errors here...

  6. added a commit that references this issue on May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

3.12only security fixesbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions