Repository navigation
normalize namespace from minidom #44376
Description
| BPO | 1621421 |
|---|---|
| Nosy | @devdanzin |
| Dependencies | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2006-12-23.20:01:44.000>
labels = ['expert-XML', 'type-bug']
title = 'normalize namespace from minidom'
updated_at = <Date 2014-02-03.19:21:26.409>
user = 'https://bugs.python.org/paulpach'bugs.python.org fields:
activity = <Date 2014-02-03.19:21:26.409>
actor = 'BreamoreBoy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['XML']
creation = <Date 2006-12-23.20:01:44.000>
creator = 'paulpach'
dependencies = ['1371937']
files = ['7679', '7680']
hgrepos = []
issue_num = 1621421
keywords = ['patch']
message_count = 7.0
messages = ['51605', '51606', '51607', '51608', '51609', '84599', '110515']
nosy_count = 4.0
nosy_names = ['jorend', 'ajaksu2', 'paulpach', 'admp']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1621421'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']
Activity
paulpach commentedon Dec 23, 2006
This is a patch that fixes bug 1371937, along with a test case that reproduces the original problem.
The patch is a port of the algorithm described here pretty much verbatim:
http://www.w3.org/TR/DOM-Level-3-Core/namespaces-algorithms.html#normalizeDocumentAlgo
to resolve namespace declarations. The patch also calls the normalizeNamespace method before calling writexml
Note the patch is against minidom that comes with python 2.5, NOT WITH PYXML. I need this for an embedded project where pyxml is too big.
paulpach commentedon Dec 23, 2006
File Added: normalizeNamespace.diff
paulpach commentedon Dec 24, 2006
File Added: normalizeNamespace.diff
paulpach commentedon Dec 24, 2006
File Added: test_toxml.py
jorend commentedon Mar 15, 2007
Thanks for the patch.
I think this is probably *not* desirable in this form. As a side effect of writexml(), this fixes up tagNames and attributes of elements in the document. DOM Level 3 Load and Save made the opposite decision: "The XML data is written to a string or an output stream. Any changes or fixups made during the serialization affect only the serialized data. The Document object and its children are never altered by the serialization operation." -- http://www.w3.org/TR/2004/REC-DOM-Level-3-LS-20040407/load-save.html#LS-LSSerializer (first paragraph) I think that is the right approach.
The new method Element.normalizeNamespace() isn't really a DOM method, though the appendix sort of makes it look that way.
Incomplete - no doc patch. (I think there's also a bug in the line added to Document.writexml()-- can't Documents have children that aren't Elements?)
devdanzin commentedon Mar 30, 2009
Patch has tests, fixes bpo-1371937.
BreamoreBoy commentedon Jul 16, 2010
msg51609 doesn't seem too enthusiastic about the patch. msg84599 states unit tests are provided and bpo-1371937 is fixed. Can we have a definitive statement as to whether the patch is acceptable or not.
devdanzin commentedon Sep 20, 2025
The tests don't run correctly, so they cannot be uses as-is to assess the fix. Given the 15 years without an update on this issue, I'm setting it to pending. If someone wants to update the tests and patch, we can keep it open until it's fixed.
serhiy-storchaka commentedon Sep 13, 2026
#156674 fixes this in the way @jorend asked for in 2007:
Element.writexml()writes the namespace declarations which are missing for the element and its attributes, without changing the document, as DOM Level 3 LS requires. It covers the cases of @paulpach's patch and test (an element and an attribute created withcreateElementNS()/setAttributeNS(), a prefix declared for an ancestor, the default namespace, an attribute in a namespace without a prefix), plusxmlns=""for an element in no namespace under a default namespace, and it reuses a prefix which is already bound to the namespace instead of inventing one.The
normalizeNamespaces()algorithm of DOM Level 3 Core is not implemented, that is a separate feature.Merge remote-tracking branch 'upstream/main' into pythongh-44376-ns-f…
gh-44376: Write missing namespace declarations in xml.dom.minidom (GH…
pythongh-44376: Write missing namespace declarations in xml.dom.minid…