Repository navigation
xml.dom documents wrong exceptions for some methods #156635
Description
Node.insertBefore(), Node.removeChild() and Node.replaceChild() are documented as raising ValueError if the node is not a child of this node, but they raise NotFoundErr, which is not a ValueError.
>>> import xml.dom.minidom
>>> doc = xml.dom.minidom.parseString('<r><c/></r>')
>>> doc.documentElement.removeChild(doc.createElement('x'))
xml.dom.NotFoundErrElement.removeAttribute() is documented as raising NotFoundErr if there is no matching attribute, and Element.removeAttributeNS() is documented as raising nothing. Both raise NotFoundErr, so the two descriptions contradict each other. The DOM specifies that removing an absent attribute has no effect, so this is a deviation of xml.dom.minidom and should be documented in its documentation.
Affects all maintained versions.
Linked PRs
- gh-156635: Fix the exceptions in the xml.dom documentation #156636
- [3.15] gh-156635: Fix the exceptions in the xml.dom documentation (GH-156636) #156637
- [3.14] gh-156635: Fix the exceptions in the xml.dom documentation (GH-156636) #156638
- [3.13] gh-156635: Fix the exceptions in the xml.dom documentation (GH-156636) #156639
Activity
gh-156635: Fix the exceptions in the xml.dom documentation (GH-156636)
[3.14] gh-156635: Fix the exceptions in the xml.dom documentation (GH…
[3.13] gh-156635: Fix the exceptions in the xml.dom documentation (GH…
[3.15] gh-156635: Fix the exceptions in the xml.dom documentation (GH…
pythongh-156635: Fix the exceptions in the xml.dom documentation (pyt…