_remote_debugging/module.c defines Py_MOD_GIL_NOT_USED twice

Bug report

It uses two definitions of Py_MOD_GIL_NOT_USED. First one in the slots (as it should be):

cpython/Modules/_remote_debugging/module.c

Lines 2345 to 2351 in 9a61d1c

    
           static PyModuleDef_Slot remote_debugging_slots[] = { 
        
               _Py_ABI_SLOT, 
        
               {Py_mod_exec, _remote_debugging_exec}, 
        
               {Py_mod_multiple_interpreters, Py_MOD_PER_INTERPRETER_GIL_SUPPORTED}, 
        
               {Py_mod_gil, Py_MOD_GIL_NOT_USED}, 
        
               {0, NULL}, 
        
           };

Second one in _remote_debugging_exec:

cpython/Modules/_remote_debugging/module.c

Lines 1627 to 1629 in 9a61d1c

    
           #ifdef Py_GIL_DISABLED 
        
               PyUnstable_Module_SetGIL(m, Py_MOD_GIL_NOT_USED); 
        
           #endif

These two ways set the same requires_gil field in the module struct: ((PyModuleObject *)module)->md_requires_gil = requires_gil;, so there's no need to duplicate this. PyUnstable_Module_SetGIL is used for single-phase-initialization modules.

I will send a PR removing the PyUnstable_Module_SetGIL call.

Linked PRs

gh-151584: Remove `PyUnstable_Module_SetGIL` call in `_remote_debuggi…

[3.15] gh-151584: Remove `PyUnstable_Module_SetGIL` call in `_remote_…

pythongh-151584: Remove `PyUnstable_Module_SetGIL` call in `_remote_d…

Navigation Menu

Repository navigation

`_remote_debugging/module.c` defines `Py_MOD_GIL_NOT_USED` twice #151584

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	static PyModuleDef_Slot remote_debugging_slots[] = {
	_Py_ABI_SLOT,
	{Py_mod_exec, _remote_debugging_exec},
	{Py_mod_multiple_interpreters, Py_MOD_PER_INTERPRETER_GIL_SUPPORTED},
	{Py_mod_gil, Py_MOD_GIL_NOT_USED},
	{0, NULL},
	};

	#ifdef Py_GIL_DISABLED
	PyUnstable_Module_SetGIL(m, Py_MOD_GIL_NOT_USED);
	#endif

_remote_debugging/module.c defines Py_MOD_GIL_NOT_USED twice #151584

Description

Bug report

Linked PRs

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`_remote_debugging/module.c` defines `Py_MOD_GIL_NOT_USED` twice #151584