syslogmodule.c lack of NULL check

Bug description:

Line 178 in 7ec1742

    
           if (PySys_Audit("syslog.openlog", "Oll", ident ? ident : Py_None, logopt, facility) < 0) {

After in if body we use Py_DECREF(indent), which can cause null pointer dereference

CPython versions tested on:

CPython main branch

Operating systems tested on:

Other

Additional information

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Reporter: Burkov Egor (eburkov@rvision.ru).

Organization: R-Vision (support@rvision.ru).

Linked PRs

Do you want to provide a PR?

Do you want to provide a PR?

yes, sure

pythongh-129345: null check for indent syslogmodule

Quick reproducer for a test case:

import syslog
import sys

sys.argv = None
def audit(event, _):
    if event == "syslog.openlog":
        raise RuntimeError("I didn't expect the spanish inquisition")

sys.addaudithook(audit)
syslog.openlog()

gh-129345: null check for indent syslogmodule (#129348)

pythongh-129345: null check for indent syslogmodule (pythonGH-129348)

[3.12] gh-129345: null check for indent syslogmodule (GH-129348) (#12…

[3.13] gh-129345: null check for indent syslogmodule (GH-129348) (#12…

Navigation Menu

Repository navigation

syslogmodule.c lack of NULL check #129345

Bug description:

CPython versions tested on:

Operating systems tested on:

Additional information

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

syslogmodule.c lack of NULL check #129345

Description

Bug description:

CPython versions tested on:

Operating systems tested on:

Additional information

Linked PRs

Activity

serhiy-storchaka commented on Jan 27, 2025

wooffie commented on Jan 27, 2025

ZeroIntensity commented on Jan 27, 2025

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions