Skip to content

Typecheck can be added to _pydatetime.timedelta.__new__ #126947

Closed

Description

@bombs-kim

Feature or enhancement

Proposal:

It seems that a typecheck can be added as suggested by the existing comment

    def __new__(cls, days=0, seconds=0, microseconds=0,
                milliseconds=0, minutes=0, hours=0, weeks=0):
        # Doing this efficiently and accurately in C is going to be difficult
        ...

        # XXX Check that all inputs are ints or floats.

Currently, an error is raised, but it's not explicit that it's because of an argument of wrong type

_pydatetime.timedelta(seconds='1')
# TypeError: can only concatenate str (not "int") to str

If this type check is not desirable, I think we can simply remove the comment.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

Activity

  1. added
    stdlibStandard Library Python modules in the Lib/ directory
    on Nov 18, 2024
  2. added a commit that references this issue on Nov 19, 2024
  3. added a commit that references this issue on Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytype-featureA feature request or enhancement

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions