Morsel.__init__ loops reserved values and could be replaced with a simple dict update  #126156

Activity

1. bdraco

   added a commit that references this issue on Oct 30, 2024

   pythongh-126156: Improve performance of creating `Morsel` objects

   ...

   2d307cb
2. bdraco commented on Oct 30, 2024

   

   bdraco

   on Oct 30, 2024

   Last edited by bdraco

   ContributorAuthor

   More actions

   (venv) bdraco cpython % python3 morsel_bench.py
   0.33160758309531957 - original
   0.28600058297161013 - new
   (venv) bdraco cpython % cat morsel_bench.py

   from http.cookies import Morsel
   import timeit
   
   
   class FastMorsel(dict):
       """A class to hold ONE (key, value) pair.
   
       In a cookie, each such pair may have several attributes, so this class is
       used to keep the attributes associated with the appropriate key,value pair.
       This class also includes a coded_value attribute, which is used to hold
       the network representation of the value.
       """
   
       # RFC 2109 lists these attributes as reserved:
       #   path       comment         domain
       #   max-age    secure      version
       #
       # For historical reasons, these attributes are also reserved:
       #   expires
       #
       # This is an extension from Microsoft:
       #   httponly
       #
       # This dictionary provides a mapping from the lowercase
       # variant on the left to the appropriate traditional
       # formatting on the right.
       _reserved = {
           "expires": "expires",
           "path": "Path",
           "comment": "Comment",
           "domain": "Domain",
           "max-age": "Max-Age",
           "secure": "Secure",
           "httponly": "HttpOnly",
           "version": "Version",
           "samesite": "SameSite",
       }
   
       _reserved_defaults = {key: "" for key in _reserved}
   
       _flags = {"secure", "httponly"}
   
       def __init__(self):
           # Set defaults
           self._key = self._value = self._coded_value = None
   
           # Set default attributes
           dict.update(self, self._reserved_defaults)
   
   
   print(timeit.timeit("Morsel()", globals={"Morsel": Morsel}))
   print(timeit.timeit("FastMorsel()", globals={"FastMorsel": FastMorsel}))
3. picnixz

   added

   type-featureA feature request or enhancementA feature request or enhancement

   performancePerformance or resource usagePerformance or resource usage

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Oct 30, 2024
4. hauntsaninja

   added a commit that references this issue on Oct 31, 2024

   gh-126156: Improve performance of creating `Morsel` objects (#126157)

   ...

   dd3c0fa
5. erlend-aasland

   closed this as completedon Nov 1, 2024
6. picnixz

   added a commit that references this issue on Dec 8, 2024

   pythongh-126156: Improve performance of creating `Morsel` objects (py…

   ...

   ca53a1a
7. ebonnal

   added a commit that references this issue on Jan 12, 2025

   pythongh-126156: Improve performance of creating `Morsel` objects (py…

   ...

   ebca2d0