Skip to content

Some weird make test behavior #125669

Closed
Closed

Description

@warsaw

Bug report

Bug description:

To varying degrees, this affects the 3.12, 3.13, and main branches. Other branches are also probably affected but I haven't tested them. They aren't showstoppers, but they are annoying.

  1. make test breaks the terminal. All input is hidden until you run the reset command.
  2. Tcl/Tk tests hijack keyboard input. This is doesn't seem to affect 3.12, moderately affects 3.13, and really breaks on main. Essentially the tests pop up tons of windows, lots of stuff happens in those windows, and while that test is running, the desktop is largely unusable. You can get some mouse events through, but no keyboard events. It's especially bad with main - you basically can't get anything done until the tests complete.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Linked PRs

Activity

  1. added
    type-bugAn unexpected behavior, bug, or error
    on Oct 17, 2024
  2. brandtbucher commented on Oct 18, 2024

    @brandtbucher
    Member

    I'm definitely in favor of changing this. I use make test locally, and it's become increasingly frustrating to try to do anything while tests are running. If people really need to test GUI stuff locally like this, maybe we can provide them with an additional make target.

  3. tomasr8 commented on Oct 18, 2024

    @tomasr8
    Member

    To turn off all GUI tests, you can disable the gui resource: EXTRATESTOPTS="-uall,-gui" make test, though maybe it should be the default for make test?

  4. added 2 commits that reference this issue on Oct 19, 2024
  5. sobolevn commented on Oct 19, 2024

    @sobolevn
    Member

    I proposed changing the --fast-ci definition to not spawn these windows: #125730

  6. added
    testsTests in the Lib/test dir
    buildThe build process and cross-build
    infraCI, GitHub Actions, buildbots, Dependabot, etc.
    on Oct 21, 2024
  7. added a commit that references this issue on Oct 30, 2024
  8. sobolevn commented on Oct 30, 2024

    @sobolevn
    Member

    Now we have make ci for CIs that will run GUI tests and make test won't by default.
    Use make test TESTOPTS="-ugui" if you still want to run GUI tests and use make test.

  9. added a commit that references this issue on Dec 8, 2024
  10. added a commit that references this issue on Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildThe build process and cross-buildinfraCI, GitHub Actions, buildbots, Dependabot, etc.testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions