Skip to content

Element.extend hides exceptions from underlying generators. #123213

New issue
New issue
Closed
Closed
Element.extend hides exceptions from underlying generators.#123213
Labels
topic-XMLtype-bugAn unexpected behavior, bug, or error

Description

@bharel
bharel
opened on Aug 22, 2024

Bug report

Bug description:

>>> from xml.etree.ElementTree import Element
>>> Element("a").extend(Element("a") for i in range(10)) # works
>>> Element("a").extend(1/0 for i in range(10)) # throws unrelated TypeError
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: expected sequence, not "generator"

C-implementation only bug.

Submitting a patch...

CPython versions tested on:

3.12, 3.13, CPython main branch

Operating systems tested on:

macOS, Windows

Linked PRs

Activity

  1. bharel
    added
    type-bugAn unexpected behavior, bug, or error
    on Aug 22, 2024

  2. bharel commented on Aug 22, 2024

    @bharel
    bharel
    on Aug 22, 2024
    ContributorAuthor

    Also happens on assignment:

    >>> Element("a")[:1] = (1/0 for i in range(1))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: expected sequence, not "generator"

    Patching up...

  3. bharel
    changed the title [-]ElementTree.extend hides exceptions from underlying generators.[/-] [+]Element.extend hides exceptions from underlying generators.[/+] on Aug 22, 2024
  4. picnixz
    added
    topic-XML
    on Aug 22, 2024
  5. serhiy-storchaka
    added a commit that references this issue on Aug 23, 2024

    gh-123213: Fixed xml.etree.ElementTree.Element.extend and assignment …

    90b6d0e
  6. miss-islington
    added 2 commits that reference this issue on Aug 23, 2024

    pythongh-123213: Fixed xml.etree.ElementTree.Element.extend and assig…

    84735b7

    pythongh-123213: Fixed xml.etree.ElementTree.Element.extend and assig…

    6ede9d4

  7. bharel commented on Aug 23, 2024

    @bharel
    bharel
    on Aug 23, 2024
    ContributorAuthor

    Fixed 🎉

  8. bharel
    closed this as completedon Aug 23, 2024
  9. Yhg1s
    added a commit that references this issue on Sep 2, 2024

    [3.13] gh-123213: Fixed xml.etree.ElementTree.Element.extend and assi…

    d9e4c4b
  10. hugovk
    added a commit that references this issue on Sep 6, 2024

    [3.12] gh-123213: Fixed xml.etree.ElementTree.Element.extend and assi…

    747abc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic-XMLtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions